Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake tries to install libfmt #5805

Closed
Eragonfr opened this issue Mar 24, 2024 · 3 comments · Fixed by #5808
Closed

cmake tries to install libfmt #5805

Eragonfr opened this issue Mar 24, 2024 · 3 comments · Fixed by #5808
Assignees

Comments

@Eragonfr
Copy link

Eragonfr commented Mar 24, 2024

I'm trying to fix the new archlinux pioneer package. All commands are taken from their build script here.
https://gitlab.archlinux.org/archlinux/packaging/packages/pioneer

Observed behaviour

After build cmake --install tries to install libfmt in the system

Expected behaviour

libfmt is not installed by cmake

Steps to reproduce

Build with

cmake -S . -B build -G Ninja \
  -D CMAKE_INSTALL_PREFIX:PATH=/usr/local \ # Changed the prefix path because I don't want to put non-packaged stuff in /usr
  -D PIONEER_DATA_DIR:PATH=/usr/local/share/pioneer/data \
  -D USE_SYSTEM_LIBGLEW:BOOL=ON \
  -D USE_SYSTEM_LIBLUA:BOOL=ON \
  -D CMAKE_EXPORT_COMPILE_COMMANDS=1 \
  -Wno-dev

cmake --build build -j 10 --target all build-data

Install with

cmake --install build --strip

My pioneer version (and OS): Sources from release 20240314 on ArtixLinux (Arch based, the only difference is the init)

EDIT: This is the same on Archlinux official build servers.

@Web-eWorks Web-eWorks self-assigned this Mar 24, 2024
@pcercuei
Copy link
Contributor

Setting -DFMT_INSTALL=OFF should work.
(but this probably should be forced in the main CMake script, yes)

@Eragonfr
Copy link
Author

It works, thank you.

@impaktor
Copy link
Member

We want to keep this open until someone PRs the suggested change, I assume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants