Do not install libfmt by default

[orhun]

closes #5805

[Web-eWorks]

Modifying the CMakeLists.txt provided by libfmt means this change will be overwritten every time libfmt is updated. I'd strongly recommend you set(FMT_INSTALL OFF CACHE) the variable (possibly using FORCE) from the top-level CMakeLists.txt before the add_subdirectory(contrib/fmt) call.

[Web-eWorks]

Thank you for taking the time to address this issue!

[orhun]

Made the recommended change in c737816

Not sure if we still need to keep the option. Let me know how it looks!

[Web-eWorks]

I'll try to test this later today, but there should be no need to keep the modification to contrib/fmt/CMakeLists.txt.

[pcercuei]

@orhun if you git rebase -i origin/master, it will open a text editor, in which you can remove the "do not install libfmt by default" commit, and the revert commit, and only keeping the "Set FMT_INSTALL..." commit. Once you have that, you can force-push your PR with git push -f.

[orhun]

I'm not sure why the CI fails.

[pcercuei]

@orhun well it fails locally too. This is not the right syntax, it's missing a description string. This works:

set(FMT_INSTALL OFF CACHE BOOL "Enable install of libfmt" FORCE)

[orhun]

Updated, thanks!

[Web-eWorks]

Thanks for the patience! Tested locally and it all looks good.