Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve surface scan missions on high-pressure worlds #5841

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

Web-eWorks
Copy link
Member

It's come to my attention that currently no ships in the game can approach the surface of Venus, yet we generate surface scan missions there anyways. Luckily, that's a quick fix.

I've also thrown in a new section of warning text to surface scan mission ads mentioning the target body's atmospheric pressure and surface gravity when those are potentially a factor limiting the player's ability to carry out the mission.

I've chosen to treat this as an informational notice only rather than preventing the player from accepting the contract to both reduce the amount of code required and also provide maximum flexibility to the player.

This PR can be used with existing saves, though you'll have to re-generate BBS ads by jumping to a different system to clear existing missions to Venus.

Snapshot_2024-06-17_17-27-02

- Filter out extreme-pressure bodies that 95% of ships won't be able to visit (can be re-added later as high-reward special mission).
- Display target body surface pressure and gravity for surface scan ads when relevant.
@fluffyfreak
Copy link
Contributor

I'm sure we used to be able to land on Venus? What changed?

@Web-eWorks
Copy link
Member Author

Web-eWorks commented Jun 18, 2024

@fluffyfreak see #5728 - TLDR: heavy atmospheric shielding trivialized the game by letting even the biggest of space-bound bulk freighters act like submarines exploring the edge of the Marianas trench. Atmospheric shielding equipment values were changed alongside randomly generated gas giant surface pressures.

The hand-set atmosphere for Venus has ~6x more surface pressure than the next closest generated body. It's intended that the player is able to land on Venus in a properly-outfitted Wave, but the atmosphere for Venus is currently calculated with the wrong molar mass for the real-life atmospheric gasses leading to a higher surface pressure than present in real life.

This PR is a cleanup task to avoid frustrating players by asking them to do the equivalent of driving over an active lava flow in a Honda Civic 😄

@Web-eWorks Web-eWorks merged commit ad7b33b into pioneerspacesim:master Jun 26, 2024
@Web-eWorks Web-eWorks mentioned this pull request Jun 26, 2024
@Web-eWorks Web-eWorks deleted the surface-scan-pressure branch June 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants