Fix Military Drive 2 not for sale & tweaks #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding point 2, maybe rename it to "Empty" or something else. |
impaktor
changed the title
Class 2 military drives require "MILITARY" tech level, which under the hood is interpreted as tech-level 11 (because that's how Frontier implemented it). Higher military drives are available at higher tech levels. Code had a bug where in stations of higher tech level than "MILITARY", you could only buy military drive of class 1, 3, and 4, but not military drive class 2.
Removing this since player might be tricked to think this has value, being some "discovery" of alien origin, sought after by someone.
impaktor
changed the title
|
OK, I've split off News event / commodity work on a separate branch, as that will be some work beyond "small commits". I consider this ready for review. |
sturnclaw
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains multitides:
1. Fix a bug
Class 2 military drives require "MILITARY" tech level, which under the hood is interpreted as tech-level 11 (because that's how Frontier implemented it). Higher military drives are available at higher tech levels. Code had a bug where in stations of higher tech level than "MILITARY", you could only buy military drive of class 1, 3, and 4, but not military drive class 2.
I note there's equipment that has "tech level = 11" set, that is technically the same as tech level "Military". Seems to be the way I did it in #3505, so looks intentional, but not sure what the reasoning was.
I saw the bug when watching the "Pioneer - Frequently Failing" play through of the game (last screenshot from Poseidon in orbit around Neptune, level 12 station):
2. Tweak suggestion
Don't generate "Unknown commodity" to scoop - Removing this since player might be tricked to think this has value, being some "discovery" of alien origin, sought after by someone.