Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning sorted build number array #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Returning sorted build number array #2

wants to merge 1 commit into from

Conversation

banane
Copy link

@banane banane commented Jun 28, 2023 •
edited
Loading

Updating this to get a full git tag list:

  • split tag to look at builds
  • make hash of build numbers as keys (without "-r")
  • get latest build
  • get associated full tag
  • return lastest (name value) tag

@banane banane force-pushed the v1.1 branch 14 times, most recently from d9c661a to 95119d9 Compare June 28, 2023 03:14
@banane banane changed the title Returning sorted build nubmer array Returning sorted build number array Jun 28, 2023
zeevvax
zeevvax reviewed Jun 28, 2023
View reviewed changes
main.js Outdated
timestamp = timestamp.trim();
for(i=0;i<tags.length;i++){
temp_tag = tags[i];
tag_array = temp_tag.split(".");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe call this temp_tag_array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeevvax zeevvax zeevvax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banane @zeevvax