Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use declare keyword in the .d.ts files #10

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

piotr-oles
Copy link
Owner

@piotr-oles piotr-oles commented Sep 29, 2020

The dts-bundle project is not maintained anymore. There is a PR to fix an issue but no-one merges it. I could merge it as I'm part of the TypeStrong organization but I don't have a publish access. To overcome this blocker, I've copied the package and applied the fix. I didn't found any maintained package that could inline typings as dts-bundle does.

Closes: #8

📦 Published PR as canary version: 1.0.2-canary.10.71f98a5.0

✨ Test out this PR locally via:

npm install @rsql/ast@1.0.2-canary.10.71f98a5.0
npm install @rsql/builder@1.0.2-canary.10.71f98a5.0
npm install @rsql/emitter@1.0.2-canary.10.71f98a5.0
npm install @rsql/parser@1.0.2-canary.10.71f98a5.0
# or 
yarn add @rsql/ast@1.0.2-canary.10.71f98a5.0
yarn add @rsql/builder@1.0.2-canary.10.71f98a5.0
yarn add @rsql/emitter@1.0.2-canary.10.71f98a5.0
yarn add @rsql/parser@1.0.2-canary.10.71f98a5.0

The dts-bundle project is not-maintained anymore. There is a PR to fix
an issue but no-one merges it. I could merge it as I'm part of the
TypeStrong organization but I still don't have publish access. To
overcome this blocker, I've copied the package and applied the fix. I
didn't found any maintaned package that could inline typings as
dts-bundle does.

✅ Closes: #8
@piotr-oles piotr-oles added patch Increment the patch version when merged prerelease This change is available in a prerelease. labels Sep 29, 2020
@piotr-oles piotr-oles self-assigned this Sep 29, 2020
@piotr-oles piotr-oles merged commit a78a39c into master Oct 8, 2020
@github-actions
Copy link

github-actions bot commented Oct 8, 2020

🚀 PR was released in v1.0.2 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Oct 8, 2020
@piotr-oles piotr-oles deleted the fix/typings-generation branch January 10, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option to run this package with "skipLibCheck=false" not possible
1 participant