[US-642] implement simple queries #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrdytkowski
force-pushed
the
US-642-implement-simple-queries
branch
from
9a9391a to
2320805
Compare
piotrdytkowski
force-pushed
the
US-642-implement-simple-queries
branch
from
304bc68 to
691b7be
Compare
lukaszgawel
reviewed
Feb 2, 2022
| .replaceAll("(\\w)\\?", "$1#") | ||
| .split("#", -1); | ||
| if (pointerAndQuery.length > 2) { | ||
| // TODO use different exception |
There was a problem hiding this comment.
Immediately :D used JsonPatchException here, with a new custom message, thanks
lukaszgawel
approved these changes
Feb 2, 2022
meehaws
reviewed
Feb 2, 2022
| final DocumentContext nodeContext = JsonPath.parse(node.deepCopy()); | ||
|
|
||
| final JsonNode parentNode = nodeContext.read(jsonPath); | ||
| final JsonNode parentNode = nodeContext.read(pathToParent); |
There was a problem hiding this comment.
parentNode is confusing name as this can be list of nodes
meehaws
reviewed
Feb 2, 2022
| } | ||
| final String jsonPath = "$" + path.replace('/', '.') | ||
| final String[] pointerAndQuery = path | ||
| .replaceAll("(\\w)\\?", "$1#") |
There was a problem hiding this comment.
Maybe consider something less probable as a token?
or maybe even #THIS_IS_SPLIT_PLACEHOLDER#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.