-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/meteora integration #7
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cargo.toml
Outdated
@@ -66,3 +52,10 @@ borsh = "0.10.3" | |||
indicatif = "0.17" | |||
rig-core = "0.6.0" | |||
thiserror = "2.0.9" | |||
commons = { git = "https://github.com/bginsber/dlmm-sdk.git", package = "commons", version = "0.3.0", branch = "update-tokio" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we swap this to the https://github.com/MeteoraAg/dlmm-sdk root repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally
spl-token-2022 = { version = "0.9.0", features = ["no-entrypoint"] } | ||
spl-token = { version = "4.0.0", features = ["no-entrypoint"] } | ||
tokio = { version = "1.37.0", features = ["full"] } | ||
solana-account-decoder = "=2.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill have to check out this branch and see if 2.0.3 is not going to cause shenanigans
the solana >=2 sdks were not compatible with the searcher client iirc, will lyk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
easier to monitor prices & pool events by using direct raydium though, yeh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes and no, the lp layout you can carry over, rest of their lib is meh
… management, and proper documentation
@bginsber lets resolve the Cargo.toml conflict and we are good to merge:) |
ill take it from here, @bginsber, thank you so much! |
Sorry for missing the resolve comment. Happy to continue helping on other to-dos. Honestly, as soon as I read and laughed at your twitter bio I knew I had to find a way to contribute |
Meteora DEX Integration
This PR integrates the Meteora DEX, allowing users to swap tokens, manage liquidity, and claim fees using Meteora's concentrated liquidity pools.
Changes
src/meteora.rs
module with Meteora DEX functionality:commons
crateImplementation Notes
MeteoraAg/dlmm-sdk
commons
interfaces where possibleRaydium Integration
Due to Solana version compatibility issues, dependency conflicts, and the fact that Jupiter can route through Raydium, a separate issue will be created to plan the deprecation of the direct Raydium integration. This PR will focus solely on the Meteora integration. Raydium changes will be handled in a future PR.
Known Issues
Testing
Future Work
Questions for Reviewers