Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undefined from keyof result of (Pick|Omit)ByValue(Exact)? #124

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Remove undefined from keyof result of (Pick|Omit)ByValue(Exact)? #124

merged 2 commits into from
Nov 9, 2019

Conversation

vatosarmat
Copy link
Contributor

@vatosarmat vatosarmat commented Nov 9, 2019

Related issues:

Checklist

  • I have read CONTRIBUTING.md
  • I have linked all related issues above
  • I have rebased my branch

For bugfixes:

  • I have added at least one unit test to confirm the bug have been fixed
  • I have checked and updated TOC and API Docs when necessary

For new features:

  • I have added entry in TOC and API Docs
  • I have added a short example in API Docs to demonstrate new usage
  • I have added type unit tests with dts-jest

@piotrwitek
Copy link
Owner

Hey @vatosarmat ,
Thanks for the PR, could you please refresh your fork and rebase your branch because there are some unrelated changes in your commits and it's very difficult to review the changes.

Thanks.

@vatosarmat
Copy link
Contributor Author

@piotrwitek done

@piotrwitek
Copy link
Owner

Looks good, great job and thanks for contribution @vatosarmat!

@piotrwitek piotrwitek merged commit 2ae7412 into piotrwitek:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyof PickByValue<ObjectWithOptionals, SomeType> gives union with undefined
2 participants