Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Class utility #56

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Added Class utility #56

merged 2 commits into from
Jan 14, 2019

Conversation

levenleven
Copy link
Contributor

Fixes #47

piotrwitek
piotrwitek requested changes Jan 14, 2019
View reviewed changes
README.md Outdated

class Store {}

function makeStore(storeClass: Class<Store>) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include return type Store here, so it is more obvious for the user what it should be

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After that small change I'll merge

@piotrwitek piotrwitek merged commit 57a37ff into piotrwitek:master Jan 14, 2019
@piotrwitek
Copy link
Owner

Great job here @levenleven, thanks for contributing 👍

@levenleven levenleven deleted the class-util branch January 14, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrwitek piotrwitek piotrwitek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levenleven @piotrwitek