Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OmitByValue and PickByValue #65

Closed
wants to merge 1 commit into from

Conversation

MasGaNo
Copy link

@MasGaNo MasGaNo commented Feb 18, 2019

Hey @piotrwitek

Not a big deal, but I think you forget to add OmitByValue and PickByValue to the default export in index.ts, as they are already well documented in the README.md file with the import from root.

I still ignore the Exact export as it's not documented.

What do you think?

@piotrwitek
Copy link
Owner

piotrwitek commented Feb 18, 2019

I removed it because they will be refactored to follow a consistent naming convention written in this API design proposal #59

@MasGaNo
Copy link
Author

MasGaNo commented Feb 19, 2019

Oh! Indeed, I didn't make the relationship with this PR.

No problem, I understand 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants