Skip to content

Commit

Permalink
sim: m32c: opc2c: remove unused vlist variable
Browse files Browse the repository at this point in the history
When building with AddressSanitizer, sim/m32c fails with:

./opc2c -l r8c.out /home/simark/src/binutils-gdb/sim/m32c/r8c.opc > r8c.c
sim_log: r8c.out

=================================================================
==3919390==ERROR: LeakSanitizer: detected memory leaks

    Direct leak of 4 byte(s) in 1 object(s) allocated from:
        #0 0x7ffff7677459 in __interceptor_malloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cpp:145
        #1 0x55555555b3df in main /home/simark/src/binutils-gdb/sim/m32c/opc2c.c:658
        #2 0x7ffff741fb24 in __libc_start_main (/usr/lib/libc.so.6+0x27b24)

Fix the leak in main by removing the vlist variable, which seems unused.
  • Loading branch information
simark authored and vapier committed Apr 7, 2021
1 parent 56d467f commit efd86e5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 4 additions & 0 deletions sim/m32c/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2021-04-07 Simon Marchi <simon.marchi@polymtl.ca>

* opc2c.c (main): Remove vlist variable.

2021-04-02 Mike Frysinger <vapier@gentoo.org>

* aclocal.m4, configure: Regenerate.
Expand Down
3 changes: 0 additions & 3 deletions sim/m32c/opc2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,6 @@ main (int argc, char **argv)
FILE *in;
int lineno = 0;
int i;
VaryRef *vlist;

if (argc > 2 && strcmp (argv[1], "-l") == 0)
{
Expand Down Expand Up @@ -655,8 +654,6 @@ main (int argc, char **argv)

qsort (opcodes, n_opcodes, sizeof (opcodes[0]), op_cmp);

vlist = (VaryRef *) malloc (n_varies * sizeof (VaryRef));

for (i = 0; i < n_opcodes; i++)
{
int j, b, v;
Expand Down

0 comments on commit efd86e5

Please sign in to comment.