Move menu to be lower to avoid overlapping the tab bar. #3332
Conversation
|
Code coverage for golang is |
| @@ -192,6 +192,9 @@ export const Header: FC = memo(function Header() { | |||
| id="more-menu" | |||
| anchorEl={moreAnchorEl} | |||
| open={Boolean(moreAnchorEl)} | |||
| getContentAnchorEl={null} | |||
There was a problem hiding this comment.
nits, do we need to pass null here? I mean if we just pass null value, then looks like it's not necessary to mention it on the caller side.
There was a problem hiding this comment.
Firstly I do not pass null, but it does not works well. So I pass null ( I referred this stackoverflow )
it's necessary to mention it on the caller side.
What does this mean?
There was a problem hiding this comment.
sorry, it's typo. I missed not word 😓
There was a problem hiding this comment.
I see, thanks for the explanation. Looks like someone had the same idea to make that null value as a default value, not to set from the caller side, but somehow is not available on our current using version, maybe it's way outdated already 😂
Let's keep it as is, thank you 👍
|
Code coverage for javascript is |
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
|
Nice |
|
Code coverage for golang is |
|
Great improvement! |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
Code coverage for javascript is
|
What this PR does / why we need it:
Move the menu for visibility. And fix version placeholder.
before
after
Which issue(s) this PR fixes:
#3328 (comment)
Does this PR introduce a user-facing change?: