Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configure TaskRoleArn for ECS taskset #3853

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Support configure TaskRoleArn for ECS taskset #3853

merged 1 commit into from
Aug 17, 2022

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix unable to set TaskRoleArn via ECS task definition configuration

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) August 17, 2022 09:52
nghialv
nghialv approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khanhtc1202 khanhtc1202 merged commit 31edcc1 into master Aug 17, 2022
@khanhtc1202 khanhtc1202 deleted the add-task-role-arn branch August 17, 2022 09:56
@github-actions github-actions bot mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghialv nghialv nghialv approved these changes

@knanao knanao knanao approved these changes

Assignees
No one assigned
Labels
area/go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khanhtc1202 @nghialv @knanao