Rename labels matcher function and update test #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghialv
reviewed
Aug 18, 2022
pkg/config/piped.go
Outdated
| // FindPlatformProvidersByLabel finds all PlatformProviders which match the provided labels. | ||
| func (s *PipedSpec) FindPlatformProvidersByLabel(labels map[string]string, t model.ApplicationKind) []PipedPlatformProvider { | ||
| // FindPlatformProvidersByLabels finds all PlatformProviders which match the provided labels. | ||
| func (s *PipedSpec) FindPlatformProvidersByLabels(labels map[string]string, t model.ApplicationKind) ([]PipedPlatformProvider, bool) { |
There was a problem hiding this comment.
Do we really need the found return value?
I feel that only slice is enough and closer with Go conventions. 🤔
There was a problem hiding this comment.
I feel you, just want to keep this function signature as same as FindPlatformProviderByName 👍 Lets me remove it
There was a problem hiding this comment.
Addressed by 3be3f14
knanao
approved these changes
Aug 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR does:
Change the FindPlatformProvidersByLabels function signature to same as FindPlatformProviderByNameWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: