Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web update for using RBAC with resource label #4920

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #4918

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.29%. Comparing base (b1177ab) to head (c4a35d2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4920   +/-   ##
=======================================
  Coverage   29.29%   29.29%           
=======================================
  Files         321      321           
  Lines       40835    40835           
=======================================
  Hits        11964    11964           
  Misses      27913    27913           
  Partials      958      958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 marked this pull request as ready for review May 21, 2024 14:30
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) May 21, 2024 14:38
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks!

@ffjlabo
Copy link
Member

ffjlabo commented May 23, 2024

@khanhtc1202
[ASK]
Which resources do you expect to be restricted by the label?
I have concerns about the pattern resources=*{env: dev};actions=*.
PipeCD has 7 resources (application, deployment, event, piped, project, apiKey, insight), and some of them don't have the label. (e.g. piped) . 👀
https://pipecd.dev/docs-v0.47.x/user-guide/managing-controlplane/auth/#configuring-the-pipecds-roles

@khanhtc1202
Copy link
Member Author

@khanhtc1202

[ASK]

Which resources do you expect to be restricted by the label?

I have concerns about the pattern resources=*{env: dev};actions=*.

PipeCD has 7 resources (application, deployment, event, piped, project, apiKey, insight), and some of them don't have the label. (e.g. piped) . 👀

https://pipecd.dev/docs-v0.47.x/user-guide/managing-controlplane/auth/#configuring-the-pipecds-roles

To simplify users' config, your mentioned pattern will be treated as all resource which have label env:dev and if it's resource without labels, just ignore the labels. Your point is a good catch, I will think about it while implementing the server side 👍

@ffjlabo
Copy link
Member

ffjlabo commented May 23, 2024

OK, sounds nice 👍

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@khanhtc1202 khanhtc1202 merged commit 2c067bc into master May 23, 2024
14 checks passed
@khanhtc1202 khanhtc1202 deleted the policies-labels branch May 23, 2024 03:49
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants