-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web update for using RBAC with resource label #4920
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4920 +/- ##
=======================================
Coverage 29.29% 29.29%
=======================================
Files 321 321
Lines 40835 40835
=======================================
Hits 11964 11964
Misses 27913 27913
Partials 958 958 ☔ View full report in Codecov by Sentry. |
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, thanks!
@khanhtc1202 |
To simplify users' config, your mentioned pattern will be treated as all resource which have label |
OK, sounds nice 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #4918
Does this PR introduce a user-facing change?: