Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change refer from piped to pipedv1 packages #4926

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented May 29, 2024

What this PR does / why we need it:

This PR decouples pipedv1 code from piped packages by changing all referenced packages in the code

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 76.31579% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 29.33%. Comparing base (2c067bc) to head (bec378d).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/app/pipedv1/sourceprocesser/sourceprocesser.go 73.52% 6 Missing and 3 partials ⚠️
pkg/app/pipedv1/sourceprocesser/attacher.go 75.00% 5 Missing ⚠️
pkg/app/pipedv1/sourceprocesser/decrypter.go 81.81% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4926   +/-   ##
=======================================
  Coverage   29.32%   29.33%           
=======================================
  Files         321      322    +1     
  Lines       40835    40868   +33     
=======================================
+ Hits        11974    11987   +13     
- Misses      27904    27922   +18     
- Partials      957      959    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks

@khanhtc1202 khanhtc1202 merged commit 6a3a5d0 into master May 29, 2024
14 checks passed
@khanhtc1202 khanhtc1202 deleted the update-piped-v1 branch May 29, 2024 04:02
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants