Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the contributors list automatically by GitHub Actions #4930

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented May 30, 2024

What this PR does / why we need it:

Every Friday, a PR updating the contributors is automatically created at 03:00(UTC) (=12:00(JST)).
It uses make gen/contributions.

Which issue(s) this PR fixes:

Fixes #4929

Does this PR introduce a user-facing change?: N/A

  • How are users affected by this change: N/A
  • Is this breaking change: N/A
  • How to migrate (if breaking change): N/A

How it works

I tested it in my forked repository. A PR like following is created.

  • PR

    スクリーンショット 2024-05-30 15 17 59

  • Commit

    スクリーンショット 2024-05-30 15 18 07

  • Diff

    スクリーンショット 2024-05-30 15 18 17

t-kikuc added 2 commits May 30, 2024 15:19
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I just left some nits

- name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
title: "[docs][bot] Update contributors"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not [docs], so how about to remove that prefix 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I fixed!! (commit-message too)

uses: peter-evans/create-pull-request@v6
with:
title: "[docs][bot] Update contributors"
commit-message: "[docs][bot] Update contributors"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.37%. Comparing base (9bf5c33) to head (7c37b64).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4930      +/-   ##
==========================================
- Coverage   29.38%   29.37%   -0.02%     
==========================================
  Files         322      322              
  Lines       40852    40852              
==========================================
- Hits        12006    12000       -6     
- Misses      27885    27891       +6     
  Partials      961      961              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc enabled auto-merge (squash) May 30, 2024 09:33
make gen/contributions
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} # `gh` command requires this token.
- name: Create Pull Request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ask] How does it work when nothing to date?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,
then no PR will be created and the action exits.

If there are no changes (i.e. no diff exists with the checked-out base branch), no pull request will be created and the action exits silently.

https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#action-behaviour

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t-kikuc
Copy link
Member Author

t-kikuc commented Jun 6, 2024

@khanhtc1202 Would you please check this?

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you 🤖

@t-kikuc t-kikuc merged commit b20163b into master Jun 6, 2024
13 of 14 checks passed
@t-kikuc t-kikuc deleted the auto-update-contributors branch June 6, 2024 02:17
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How about automatically updating the contributors list by GitHub Actions?
3 participants