-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the contributors list automatically by GitHub Actions #4930
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I just left some nits
- name: Create Pull Request | ||
uses: peter-evans/create-pull-request@v6 | ||
with: | ||
title: "[docs][bot] Update contributors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not [docs], so how about to remove that prefix 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I fixed!! (commit-message
too)
uses: peter-evans/create-pull-request@v6 | ||
with: | ||
title: "[docs][bot] Update contributors" | ||
commit-message: "[docs][bot] Update contributors" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4930 +/- ##
==========================================
- Coverage 29.38% 29.37% -0.02%
==========================================
Files 322 322
Lines 40852 40852
==========================================
- Hits 12006 12000 -6
- Misses 27885 27891 +6
Partials 961 961 ☔ View full report in Codecov by Sentry. |
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
make gen/contributions | ||
env: | ||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} # `gh` command requires this token. | ||
- name: Create Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ask] How does it work when nothing to date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks,
then no PR will be created and the action exits.
If there are no changes (i.e. no diff exists with the checked-out base branch), no pull request will be created and the action exits silently.
https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#action-behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@khanhtc1202 Would you please check this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you 🤖
What this PR does / why we need it:
Every Friday, a PR updating the contributors is automatically created at 03:00(UTC) (=12:00(JST)).
It uses
make gen/contributions
.Which issue(s) this PR fixes:
Fixes #4929
Does this PR introduce a user-facing change?: N/A
How it works
I tested it in my forked repository. A PR like following is created.
PR
Commit
Diff