Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gen-contributions.sh: Not to remove FOSSA Status #4946

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jun 5, 2024

What this PR does / why we need it:

To keep 'FOSSA Status' even after make gen/contributions because it needs update due to
8326ad0

Does this PR introduce a user-facing change?: N/A

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.38%. Comparing base (600bd8f) to head (fb8a5e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4946   +/-   ##
=======================================
  Coverage   29.38%   29.38%           
=======================================
  Files         322      322           
  Lines       40852    40852           
=======================================
  Hits        12004    12004           
  Misses      27888    27888           
  Partials      960      960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc enabled auto-merge (squash) June 5, 2024 07:24
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I ran make gen/contributions locally, and the result seems correct.

@t-kikuc t-kikuc merged commit 8bffe1a into master Jun 5, 2024
17 of 18 checks passed
@t-kikuc t-kikuc deleted the fix-gen-contributions-fossa branch June 5, 2024 08:29
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants