Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fossabot in make gen/contributions #4960

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jun 7, 2024

What this PR does / why we need it:

Although we removed fossabot in #4945,
we need to remove it automatically when using make gen/contributoins.

Note

Even though the following sed -i won't work well on Mac, thatt doesn't matter.
That's because make gen/contributions will be used only by this GitHub Action(which uses ubuntu), not developers' PC.

# Remove fossabot from the contributors list.
sed -i '/fossabot/d' README.md.tmp

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.38%. Comparing base (b20163b) to head (35292c8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4960      +/-   ##
==========================================
- Coverage   29.38%   29.38%   -0.01%     
==========================================
  Files         322      322              
  Lines       40852    40852              
==========================================
- Hits        12006    12004       -2     
- Misses      27885    27888       +3     
+ Partials      961      960       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc merged commit 38a7cbb into master Jun 10, 2024
17 of 18 checks passed
@t-kikuc t-kikuc deleted the fix-update-contribution-sed branch June 10, 2024 04:45
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants