-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default env for script run #5002
Conversation
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5002 +/- ##
==========================================
+ Coverage 22.25% 22.28% +0.02%
==========================================
Files 519 519
Lines 57234 57284 +50
==========================================
+ Hits 12739 12766 +27
- Misses 43468 43492 +24
+ Partials 1027 1026 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
"SR_TRIGGERED_AT": strconv.FormatInt(src.TriggeredAt, 10), | ||
"SR_TRIGGERED_COMMIT_HASH": src.TriggeredCommitHash, | ||
"SR_REPOSITORY_URL": src.RepositoryURL, | ||
"SR_RAW": string(b), // Add the raw json string as an environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about renaming it to SR_CONTEXT_RAW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, cheged at a9aac93
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
oops, I forgot to add the |
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with this PR and the Deployment model.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you go 🚀
* Add default env for script run Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Add default env for script run rollback Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Make ContextInfo to use deployment info for script run stage Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Add docs Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Change env name Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Add test Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Add Summary value Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Set omitempty Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> --------- Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
What this PR does / why we need it:
Added default env value for the deployment information (such as deployment id, application id...)
Current values are below.
env:prd
andteam:server
,SR_LABEL_ENV
andSR_LABEL_TEAM
are registered.example of app.pipecd.yaml
Which issue(s) this PR fixes:
Fixes #4814
Does this PR introduce a user-facing change?: