Remove GetReadOnly from deploysource.Provider interface #5048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes GetReadOnly from deloysource.Provider interface in pipedv1 package. The implementation of GetReadOnly does not provide any protections but only means that "please ensure not to modify the deploy source" or things will go wrong.
Concerning point: The GetReadOnly does not copy the deploy source directory, while the Get interface does, which means using the Get interface is more costly than using the GetReadOnly. But, for the new implementation of pipedv1, we will introduce another mechanism for controlling the deploy source, which is: instead of lazied cloning the deployment source (as the current usage of the deploy source package), we will force the piped clone the deployment source before call to plugins interfaces.
Also, this change is in the pipedv1 package, which means it would not affect our current users 👍
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: