-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type for grpcWeb.Error to grpcweb.RpcError #5072
Conversation
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5072 +/- ##
=======================================
Coverage 22.79% 22.79%
=======================================
Files 410 410
Lines 43382 43382
=======================================
Hits 9891 9891
Misses 32712 32712
Partials 779 779 ☔ View full report in Codecov by Sentry. |
Sorry about that, lol. |
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
) * fix: upgrade dotenv from 8.2.0 to 8.6.0 (#5037) Snyk has created this PR to upgrade dotenv from 8.2.0 to 8.6.0. See this package in yarn: dotenv See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * fix: upgrade @types/yup from 0.29.11 to 0.29.14 (#5038) Snyk has created this PR to upgrade @types/yup from 0.29.11 to 0.29.14. See this package in yarn: @types/yup See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * fix: upgrade react-draggable from 4.4.3 to 4.4.6 (#5039) Snyk has created this PR to upgrade react-draggable from 4.4.3 to 4.4.6. See this package in yarn: react-draggable See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * fix: upgrade clsx from 1.1.1 to 1.2.1 (#5040) Snyk has created this PR to upgrade clsx from 1.1.1 to 1.2.1. See this package in yarn: clsx See this project in Snyk: https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * add EphemeralStorage to RegisterTaskDefinition() (#5063) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Remove platform provider migration ops task (#5065) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Remove unused dependencies: @date-io/dayjs, @material-ui/pickers (#5070) * yarn remove @date-io/dayjs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * yarn remove @material-ui/pickers Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix type for grpcWeb.Error to grpcweb.RpcError (#5072) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Release/init v0.48.3 (#5090) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
What this PR does / why we need it:
I found the type some errors. This is for type grpcWeb.RpcError.
From grpc-web 1.3.0, grpcWeb.Error has changed to grpcWeb.RpcError.
https://github.com/grpc/grpc-web/releases/tag/1.3.0
I checked the type error for grpcWeb.Error disappeared.
Before
After
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: