Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for Grafana Tempo datasource #5167

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Add config for Grafana Tempo datasource #5167

merged 1 commit into from
Sep 4, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Aug 30, 2024

What this PR does / why we need it:

Add Grafana Tempo at the control plane.
Additionally, configure the OpenTelemetry Collector to send traces to the Grafana Tempo.

Which issue(s) this PR fixes:

Fixes #4977

Does this PR introduce a user-facing change?: Yes

  • How are users affected by this change:
    the control plane has new components
  • Is this breaking change:
    No
  • How to migrate (if breaking change):
    N/A

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.89%. Comparing base (6a432ed) to head (8b7f3b2).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5167   +/-   ##
=======================================
  Coverage   22.89%   22.89%           
=======================================
  Files         415      415           
  Lines       44223    44223           
=======================================
  Hits        10125    10125           
  Misses      33310    33310           
  Partials      788      788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Warashi Warashi merged commit b7e6b9d into master Sep 4, 2024
18 checks passed
@Warashi Warashi deleted the grafana-tempo branch September 4, 2024 01:28
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the way to export the deployment traces.
3 participants