Discard otel errors #5193
Merged
Discard otel errors #5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Warashi
commented
Sep 6, 2024
Comment on lines
+240
to
+244
| // if control plane's flag monitoring.enabled is false, otel provider logs errors. | ||
| // it's no problem but we don't want to see it. | ||
| // so we discard the errors and the logs. | ||
| otel.SetErrorHandler(otel.ErrorHandlerFunc(func(err error) {})) | ||
| otel.SetLogger(logr.Discard()) |
There was a problem hiding this comment.
we have to set global ErrorHandler and Logger before we create the tracer providers.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5193 +/- ##
==========================================
- Coverage 22.86% 22.84% -0.02%
==========================================
Files 420 420
Lines 45247 45245 -2
==========================================
- Hits 10344 10338 -6
- Misses 34108 34112 +4
Partials 795 795 ☔ View full report in Codecov by Sentry. |
t-kikuc
approved these changes
Sep 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR discards all errors and logs from the otel library.
Without this PR, we will see error logs when an error occurs, like the one below.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: