Remove pipectl quickstart command #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
requested review from
nghialv,
kentakozuka,
ffjlabo,
t-kikuc and
Warashi
as code owners
t-kikuc
reviewed
Oct 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5268 +/- ##
==========================================
+ Coverage 24.08% 24.28% +0.19%
==========================================
Files 441 440 -1
Lines 47099 46754 -345
==========================================
+ Hits 11345 11352 +7
+ Misses 34850 34499 -351
+ Partials 904 903 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
|
@t-kikuc You're right, I remove that as well 👍 |
t-kikuc
approved these changes
Oct 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Remove pipectl quickstart command Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Remove the quickstart from docs Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
t-kikuc
added a commit
that referenced
this pull request
Oct 9, 2024
* Fix the workflow publishes quickstart manifests (#5266) * Add pull-requests permission to the workflow Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Set the base branch to the default branch of the repository Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Use `github.ref_name` to determine the version of manifests Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Checkout master branch to make PR to master branch Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Remove pipectl quickstart command (#5268) * Remove pipectl quickstart command Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> * Remove the quickstart from docs Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Enabled to configure the interval of livestate store for Lambda (#5269) * add liveStateInterval for Lambda Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add docs of liveStateInterval Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix a test Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Rename to 'awsAPIPollingInterval' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update RELEASE to v0.49.2 and sync docs of v0.49.x (#5272) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We will use kubectl with quickstart manifests for quickstart, instead of pipectl quickstart command
Which issue(s) this PR fixes:
Fixes #5148
Does this PR introduce a user-facing change?: