Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command-line-tool.md: GCR to GHCR #5286

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

Reimei1213
Copy link
Contributor

What this PR does:

We migrated from GCR to GHCR, but the documentation still mentioned GCR, so I updated it accordingly.

Why we need it:

We moved to use ghcr instead

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

We migrated from GCR to GHCR, but the documentation still mentioned GCR, so I updated it accordingly.

Signed-off-by: reimei <34594195+Reimei1213@users.noreply.github.com>
@khanhtc1202
Copy link
Member

Nice catch, thanks @Reimei1213 👍
Could you update the /docs-dev version of this docs too? (same file name but under the docs-dev dir)

Signed-off-by: reimei <kakibo1213@gmail.com>
@Reimei1213
Copy link
Contributor Author

@khanhtc1202
I've corrected it, please check 🙇

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!!

@t-kikuc t-kikuc changed the title Update command-line-tool.md Fix command-line-tool.md: GCR to GHCR Oct 23, 2024
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@khanhtc1202 khanhtc1202 merged commit 2acb054 into pipe-cd:master Oct 23, 2024
13 of 15 checks passed
@Reimei1213 Reimei1213 deleted the patch-1 branch October 23, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants