Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC pipedv1 starts plugins #5394

Merged
merged 1 commit into from
Dec 9, 2024
Merged

PoC pipedv1 starts plugins #5394

merged 1 commit into from
Dec 9, 2024

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Dec 6, 2024

What this PR does:

Implement logic for piped call plugins, which includes

  • pipedv1 starts/stops plugins
  • pipedv1 prepares plugins' clients
  • controller prepares stage based plugin map and passes to planners/schedulers for tasks execution

Why we need it:

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 95 lines in your changes missing coverage. Please review.

Project coverage is 25.73%. Comparing base (25c55a2) to head (30f6fe0).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 58 Missing ⚠️
pkg/app/pipedv1/controller/controller.go 0.00% 19 Missing ⚠️
pkg/configv1/piped.go 0.00% 15 Missing ⚠️
pkg/app/pipedv1/controller/planner.go 0.00% 2 Missing ⚠️
pkg/app/pipedv1/controller/scheduler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5394      +/-   ##
==========================================
- Coverage   25.81%   25.73%   -0.09%     
==========================================
  Files         450      449       -1     
  Lines       48357    48401      +44     
==========================================
- Hits        12484    12455      -29     
- Misses      34902    34974      +72     
- Partials      971      972       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202 khanhtc1202 merged commit ee77b98 into master Dec 9, 2024
16 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the piped-call-plugins-init branch December 9, 2024 02:06
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants