-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugins build command to makefile #5402
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5402 +/- ##
=======================================
Coverage 25.74% 25.74%
=======================================
Files 449 449
Lines 48452 48452
=======================================
Hits 12474 12474
Misses 35005 35005
Partials 973 973 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I commented on one nitpick
Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
as title. Sample output
Why we need it:
This command is needed while testing plugins with pipedv1
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: