Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugins build command to makefile #5402

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

khanhtc1202
Copy link
Member

What this PR does:

as title. Sample output

❯ make build/plugin PLUGINS=kubernetes
mkdir -p ~/.pipecd/plugins
Building plugins...
Building plugin: kubernetes
Plugins are built and copied to ~/.pipecd/plugins

Why we need it:

This command is needed while testing plugins with pipedv1

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.74%. Comparing base (74de8a0) to head (3fc60ce).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5402   +/-   ##
=======================================
  Coverage   25.74%   25.74%           
=======================================
  Files         449      449           
  Lines       48452    48452           
=======================================
  Hits        12474    12474           
  Misses      35005    35005           
  Partials      973      973           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

t-kikuc
t-kikuc previously approved these changes Dec 10, 2024
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I commented on one nitpick

Makefile Outdated Show resolved Hide resolved
Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit 446a643 into master Dec 10, 2024
14 of 16 checks passed
@khanhtc1202 khanhtc1202 deleted the add-plugin-build-command branch December 10, 2024 04:51
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants