[k8s plugin] Prepare for implementing livestate apis #5510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
… retrieval Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
…ve state management Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5510 +/- ##
==========================================
+ Coverage 26.19% 26.55% +0.35%
==========================================
Files 464 465 +1
Lines 49815 49958 +143
==========================================
+ Hits 13049 13266 +217
+ Misses 35733 35633 -100
- Partials 1033 1059 +26 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
khanhtc1202,
ffjlabo and
t-kikuc
as code owners
ffjlabo
approved these changes
Jan 31, 2025
Comment on lines
+47
to
+48
| // BuildApplicationLiveState builds the live state of the application from the given manifests. | ||
| func BuildApplicationLiveState(deploytarget string, manifests []Manifest, now time.Time) *model.ApplicationLiveState { |
There was a problem hiding this comment.
memo: If possible, it would be nice to implement it under the live state package.
I got the thought to hide the Manifest.body from the other package.
Not consider for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
GetLiveResourcesin the provider package and use it from the deployment packageBuildApplicationLiveStateto implement the livestate featureWhy we need it:
To implement the livestate API for plugin-architectured piped.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: