Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PlatformProvider from pipedv1 config #5511

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

khanhtc1202
Copy link
Member

What this PR does:

as title

Why we need it:

The PlatformProvider and CloudProvider are no more be used in pipedv1 config

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 26.10%. Comparing base (90170ba) to head (459136d).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5511      +/-   ##
==========================================
- Coverage   26.19%   26.10%   -0.10%     
==========================================
  Files         464      464              
  Lines       49815    49684     -131     
==========================================
- Hits        13049    12969      -80     
+ Misses      35733    35687      -46     
+ Partials     1033     1028       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@t-kikuc
Copy link
Member

t-kikuc commented Jan 29, 2025

It seems good.

How about creating a list of deprecated features in pipedv1 somewhere so that we can announce them without omission?

(e.g. Issue? Label?)

@khanhtc1202
Copy link
Member Author

@t-kikuc That sound good, let do it separately, since this removal change in this PR does not related to deprecated features or not 👀

@t-kikuc
Copy link
Member

t-kikuc commented Jan 30, 2025

Yes, of course do it separately.
just reminded before merging👍

@khanhtc1202 khanhtc1202 merged commit 6f4d443 into master Jan 30, 2025
16 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the update-pipedv1-config branch January 30, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants