-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoiseReduce Service Added #324
Conversation
@@ -0,0 +1,36 @@ | |||
|
|||
import noisereduce as nr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a try/catch here and advise the user to do pip install pipecat[noisereduce]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do this in other services.
self.reduce_noise(frame) | ||
await self.push_frame(frame, direction) | ||
|
||
def reduce_noise(self, frame: AudioRawFrame): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefix with underscore for private functions _reduce_noise
|
||
noisereduce==3.0.2 | ||
# via noisereduce | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have these files anymore.
@@ -490,6 +490,8 @@ werkzeug==3.0.3 | |||
# via flask | |||
yarl==1.9.4 | |||
# via aiohttp | |||
noisereduce==3.0.2 | |||
# via noisereduce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have this file anymore.
@@ -0,0 +1,36 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move the file to processors/audio
please? this is not actually a third-party service but just a processor.
on calls. Important for calls run through Twilio. Added example: | ||
`examples/foundational/07c-i-interruptible-deepgram-noisereduce.py` of noisereduce | ||
with DeepgramSTT | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will need to move this much higher in the file now :-D.
@ankykong Thank you so much for this and so sorry for the loooooong delay. 🙏 This needs a rebase and added a few minor comments. But looks great! |
This has been implemented here: #611 |
No description provided.