Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM user frame processor with tests #450

Conversation

EdgarMMProsper
Copy link

Proposed solution for this issue: #441
We try to improve the processing of frames from the user, since they often arrive out of order. We also tackle the case when the VAD does not activate but we receive transcriptions.
We follow the principle: no user input should be lost.
We use interruptions for making sure the retrigger of the LLM does not create odd responses

@aconchillo aconchillo self-assigned this Oct 2, 2024
@aconchillo
Copy link
Contributor

Thank you so much @EdgarMMProsper ! We are releasing Pipecat today but I'll make sure to review this so it goes into the next release.

@skandere
Copy link

skandere commented Nov 6, 2024

@aconchillo I have been using this code since the hackathon, I found that it solved the problem of having some tokens not added to the LLM context. Would be amazing to see it merged at some point if you feel code is good :)

@aconchillo
Copy link
Contributor

@aconchillo I have been using this code since the hackathon, I found that it solved the problem of having some tokens not added to the LLM context. Would be amazing to see it merged at some point if you feel code is good :)

Cool! This validation actually helps a lot. This is definitely on the top of my list and I'm sorry I haven't looked at it and merged it before. 😞 This is coming next week for sure!

@EdgarMMProsper
Copy link
Author

Hey! I confirm that we have not touched this code in our internal codebase since this PR and we are still consistently happy about it. At some point we had to disable the interim transcriptions, because Deepgram was sending them offtime (like sending Interim Final TheSameInterimAgain)

@Vortigern-source
Copy link

Any idea when this'll be able to be merged?

@aconchillo
Copy link
Contributor

Hi! I'm moving this PR here #703. I want to move some things around. I'm keeping the origin commit and will work on top of it. I will release Pipecat 0.0.48 tomorror (Sunday) and quick smaller release with this PR after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants