-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add OpenAISTTService #459
base: main
Are you sure you want to change the base?
add OpenAISTTService #459
Conversation
@joachimchauvet Thank you!!! Any chance we can rebase and try this again? |
42e366b
to
47bb351
Compare
@aconchillo I rebased and updated to use the new SegmentedSTTService ;) |
@@ -51,6 +50,8 @@ async def main(): | |||
), | |||
) | |||
|
|||
stt = OpenAISTTService(api_key=os.getenv("OPENAI_API_KEY"), model="whisper-1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should set transcription_enabled=False
since we are using OpenAI's STT now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we should enable audio passthrough vad_audio_passthrough=True
so the audio can reach the STT.
Thank you! Looks great! Added a couple of comments. Needs a rebase as well. |
113b9d8
to
474f06e
Compare
Edit: rebased on the most recent version that doesn't have formatting issues |
474f06e
to
4757481
Compare
4757481
to
4649bdb
Compare
4649bdb
to
b7d7c51
Compare
@joachimchauvet I’m waiting.. 🙏 |
This also works with OpenAI-compatible API providers such as Groq (requested in #254) by passing the
base_url
.