fix bug and optimize keepalive #488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Oct 12, 2024
| await self._connect() | ||
| if not (self._websocket and self._websocket.open): | ||
| await super().start(frame) | ||
| await self._connect() |
There was a problem hiding this comment.
I don't think we need this anymore. StartFrame is now guaranteed to arrive first to all frames. So the self._connect() should happen before any other frame is received.
aconchillo
reviewed
Oct 12, 2024
| await self._send_text("") | ||
| current_time = time.time() | ||
| if current_time - self._last_message_time >= 10: | ||
| await self._send_text("") |
There was a problem hiding this comment.
We should update self._last_message_time otherwise we could send keepalives continuously.
|
Thank you so much! And sorry for the delay! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, connect is called before start, or the connection is already established. This can result in the “old” connection leading to a “received 1008 (policy violation)” error from ElevenLabs 20 seconds after start, due to no text being sent.
Also ensures that the keep-alive message is only sent when necessary.