Consolidate update frames classes into a single UpdateSettingsFrame class #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aconchillo
reviewed
Sep 30, 2024
src/pipecat/services/together.py
Outdated
| if frame.top_p is not None: | ||
| await self.set_top_p(frame.top_p) | ||
| if frame.extra: | ||
| await self.set_extra(frame.extra) |
There was a problem hiding this comment.
Do you mind create a function for this so we only have:
elif isinstance(frame, LLMUpdateSettingsFrame):
await self._update_setting(frame)
Just trying to keep process_frame() as short as possible, because sometimes it can get too long.
There was a problem hiding this comment.
await self._update_settings(frame) (plural)
aconchillo
reviewed
Sep 30, 2024
src/pipecat/services/openai.py
Outdated
| if frame.top_p is not None: | ||
| await self.set_top_p(frame.top_p) | ||
| if frame.extra: | ||
| await self.set_extra(frame.extra) |
aconchillo
reviewed
Sep 30, 2024
src/pipecat/services/ai_services.py
Outdated
| if frame.style_degree is not None: | ||
| await self.set_style_degree(frame.style_degree) | ||
| if frame.role is not None: | ||
| await self.set_role(frame.role) |
aconchillo
reviewed
Sep 30, 2024
src/pipecat/services/ai_services.py
Outdated
| if frame.model is not None: | ||
| await self.set_model(frame.model) | ||
| if frame.language is not None: | ||
| await self.set_language(frame.language) |
|
LGTM! Thank you for doing this! Just minor comment |
aconchillo
approved these changes
Sep 30, 2024
markbackman
force-pushed
the
mb/update-settings-frame
branch
from
b7c9bb5
to
1f77863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TTSUpdateSettingsFrame, STTUpdateSettingsFrame, and LLMUpdateSettingsFrame replace the corresponding settings frames for TTS, STT, and LLM.
@aconchillo this is to simplify the updates into a single frame, as you requested. This feels much cleaner!
Also, related to updates, I noticed that there was mixed use of
language_codeandlanguagefor TTS services, so I'm aligning tolanguagefor all services.