Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTL-5450 Install CI/CD for client-nodejs #576

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

maximlishchenko
Copy link
Contributor

CHANGELOG.md Outdated
@@ -8,6 +8,10 @@ For public Changelog covering all changes done to Pipedrive’s API, webhooks an

## [Unreleased]

### Changed
- Migrate publish flow from Jenkins to GitHub Actions
- Fix Owner name
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which owner name we are fixing?

uses: pipedrive-actions/github-actions-workflows/.github/workflows/reusable_cicd-npm-publish.yml@master
with:
revision: ${{ github.event.pull_request.head.ref }}
supported_versions: '[18]'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this and keep using the default in the .nvmrc

@maximlishchenko maximlishchenko marked this pull request as ready for review October 8, 2024 13:47
@maximlishchenko maximlishchenko added npm-version-patch used for deployment npm-ready-for-publish used for deployment labels Oct 8, 2024
pipedrive-public-gha-bot bot pushed a commit that referenced this pull request Oct 8, 2024
@maximlishchenko maximlishchenko added npm-ready-for-publish used for deployment and removed npm-ready-for-publish used for deployment labels Oct 8, 2024
pipedrive-public-gha-bot bot pushed a commit that referenced this pull request Oct 9, 2024
@pipedrive-public-gha-bot pipedrive-public-gha-bot bot merged commit 3e69d64 into master Oct 9, 2024
14 of 15 checks passed
@pipedrive-public-gha-bot pipedrive-public-gha-bot bot deleted the install-cicd-client-nodejs branch October 9, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm-ready-for-publish used for deployment npm-version-patch used for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants