Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added typecheck for ts(#52) #78

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

midhun1998
Copy link
Contributor

Adds typecheck for TypeScript files in the lint workflow of Javascript template.
Resolves: #52

Copy link
Collaborator

@oesgalha oesgalha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, @midhun1998

Thank you for contributing to the project. 👍

I've added some comments to improve the generated pipeline a little. Can you take a look?

Adds typecheck for TypeScript files in the lint workflow of Javascript template.
Resolves: pipelinit#52
Copy link
Collaborator

@oesgalha oesgalha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🎉
Thank you again for the contribution.

I'll cut a new release soon!

@oesgalha oesgalha merged commit 1093dd0 into pipelinit:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript: run typecheck in the lint stage
2 participants