Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(evmstaking/types): add test cases for params #103

Merged
merged 1 commit into from
Sep 19, 2024
Merged

test(evmstaking/types): add test cases for params #103

merged 1 commit into from
Sep 19, 2024

Conversation

zsystm
Copy link
Collaborator

@zsystm zsystm commented Sep 11, 2024 •
edited by edisonz0718
Loading

increased test coverage to 100%

changes

  • Updated the input types of validation functions to use concrete types instead of any, as there doesn’t appear to be a specific reason for using any. (Please let me know if there’s a reason for it)
  • Renamed the withdrawal test suite to avoid naming conflicts with the parameter test suite.

issue: #64

@zsystm zsystm marked this pull request as ready for review September 11, 2024 05:56
@zsystm zsystm self-assigned this Sep 12, 2024
edisonz0718
edisonz0718 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@edisonz0718 edisonz0718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zsystm
add test cases for evmstaking/types/params
76b5112 
increased test coverage to 100%

changes
validate functions use concrete type instead of any. there is no reasoning for using any.

rename withdraw test suite to avoid name conflict with param test suite
@zsystm zsystm force-pushed the zsystm/test/evmstaking/types/params branch from c78f3e4 to 76b5112 Compare September 19, 2024 06:16
@zsystm zsystm merged commit eef53b0 into piplabs:main Sep 19, 2024
6 checks passed
@zsystm zsystm mentioned this pull request Sep 22, 2024
Open
@zsystm zsystm deleted the zsystm/test/evmstaking/types/params branch September 25, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edisonz0718 edisonz0718 edisonz0718 approved these changes

@jdubpark jdubpark jdubpark approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

@ezreal1997 ezreal1997 Awaiting requested review from ezreal1997 ezreal1997 is a code owner

@limengformal limengformal Awaiting requested review from limengformal limengformal is a code owner

@Narangde Narangde Awaiting requested review from Narangde

@leeren leeren Awaiting requested review from leeren leeren is a code owner

Assignees

@zsystm zsystm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zsystm @edisonz0718 @jdubpark