feat(docker): add docker node support #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuttyYang
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal,
Narangde and
leeren
as code owners
LeoHChen
reviewed
Sep 30, 2024
| @@ -0,0 +1,11 @@ | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
can you use a lightweight base image?
There was a problem hiding this comment.
Coinbase requires using Ubuntu 20 or higher as the base image, rather than Alpine or Debian.
Signed-off-by: lutty <lutty@lutty.me>
|
Is there a way for us to unify modifications to the genesis and config files in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the #153 requirements, we need to support starting the RPC node with Docker. This PR implements the functionality to start a Story's RPC node and localnet using Docker.
issue: #153