refactor(panic): remove unused or unnecessary panic code #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edisonz0718
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
ezreal1997,
limengformal,
Narangde and
leeren
as code owners
jdubpark
approved these changes
Oct 7, 2024
| return withdrawal | ||
| } | ||
|
|
||
| // UnmarshalWithdrawal returns the withdrawal. |
There was a problem hiding this comment.
We don't use this? Interesting, wonder why we have it in the first place
There was a problem hiding this comment.
Yeah, I did not find any usage in the code base.
edisonz0718
force-pushed
the
ze/remove-unused-code
branch
from
679ecec
to
7ce8266
Compare
Binary uploaded successfully 🎉📦 Version Name: 0.10.1-unstable-e43f5e9 |
leeren
pushed a commit
to leeren/story-fork
that referenced
this pull request
Oct 10, 2024
leeren
pushed a commit
to leeren/story-fork
that referenced
this pull request
Oct 10, 2024
leeren
pushed a commit
to leeren/story-fork
that referenced
this pull request
Oct 10, 2024
leeren
pushed a commit
to leeren/story-fork
that referenced
this pull request
Oct 10, 2024
leeren
pushed a commit
that referenced
this pull request
Oct 15, 2024
leeren
pushed a commit
that referenced
this pull request
Oct 15, 2024
leeren
pushed a commit
that referenced
this pull request
Oct 15, 2024
limengformal
pushed a commit
that referenced
this pull request
Oct 15, 2024
* feat(x/evmstaking): max unbond withdrawal * chore(x/evmstaking): bump log level * feat(x/evmstaking): spendable coin max amount with tests * feat(x/evmstaking): pass zero amount * chore(x/evmstaking): move logs * chore(release): finalize client 0.10.1 stable release * chore(release): begin story v0.10.2 unstable release * feat(cmd): one block rollback (#157) add cometBFT's one block rollback cmd * chore(release): finalize client 0.10.2 stable release * chore(release): begin client 0.11.0 unstable release * fix(x/evmstaking): endblock unbond branch check (#163) * fix(x/evmstaking): branch condition on max spendable * test(x/evmstaking): add expected call in tests * feat(cli): add unjail validator subcommand (#170) * feat(cli): add unjail validator subcommand * fix: use static predeploy ca in validator logic * chore(release): finalize client 0.11.0 stable release * chore(release): begin story client v0.12.0 unstable release * feat(epochs): port epochs module from cosmos-sdk (#101) * chore: modify path for mockgen (#121) * chore(evmstaking): remove unnecessary codes (#125) * add test cases for evmstaking/types/params increased test coverage to 100% changes validate functions use concrete type instead of any. there is no reasoning for using any. rename withdraw test suite to avoid name conflict with param test suite * add test cases for evmstaking/keeper/unjail increased test coverage to 100% * add test cases for genesis increased coverage to 71.4% * fix syntax after rebase * add test cases for genesis (#112) increase coverage to 100% * fix(evmstaking): query withdrawal queue (#113) it should append QueueElementsPrefixSuffix when query elements of queue it fixes #84 * test(evmengine): add test cases for db (#120) * add test cases to db * test(evmengine): add test cases for helper (#131) * add test cases for helper increased test coverage to 100% * fix ci * add test cases for keeper (#132) increased test coverage to 89.7% add ci rule to not use t.Parallel to avoid data race issue for cosmos orm table. * test(evmengine): add test cases for genesis (#134) increase coverage to 83.3% moved common function to keeper_internal_test.go * add test cases for genesis (#135) * test(evmengine): add test cases for params (#136) increased coverage to 77.3% * add test cases for params (#137) increased coverage to 100% * feat(script): auto add binary version to s3 file (#142) * add version txt * fixed task name * fixed url * fixed url * opti title * finish test * fixed platform * fixed pre-commit * fix(evmengine): nil panic with optimistic build enabled (#128) cmtAPI is lazily set, so during replyBlocks it is nil. * test(evmengine/keeper): add test cases for msg server (#100) changes of mockEngineAPI - forceInvalidNewPayloadV3 and forceInvalidForkchoiceUpdatedV3 are added to simulate failed apis changes of engineMock - Add storeKey to make engineMock's methods dependent on sdk.Context for better testability NewBlock - Because of above changes, we need to rlp encode and decode block data. But if we create a block with nil withdrawals and nil withdrawalHash, rlp doesn't work well (couldn't figure out the root cause) - To avoid rlp error, pass non-nil withdrawals so withdrawalHash can be set as non-nil emptyHash value. * test(evmengine): add test cases for abci (#143) increased coverage to 83.8% added mock getPayloadV3Func for mocking getPayloadV3 * feat(genesis): disable vote extension by default (#173) * refactor(panic): remove unused or unnecessary panic code (#171) * feat(mint): customized mint module (#169) * feat(mint): port mint module from cosmos sdk v0.50.7 * feat(mint): port mint module from cosmos sdk v0.50.7 * feat(mint): port mint module from cosmos sdk v0.50.7 * feat(mint): port mint module from cosmos sdk v0.50.7 * feat(mint): remove useless parameters * feat(mint): new inflation function * feat(mint): mint parameters change event log processing * feat(mint): mint module api * feat(mint): placeholder for param change events * feat(mint): fix unit test * feat(mint): fix based on comments * feat(mint): fix based on comments * feat(mint): update readme * feat(mint): update readme * feat(netconf): fix genesis config of mint module in local netconf (#175) * feat(contracts): transparent proxies and el genesis (#165) * Change UUPS by TransparentUpgradeableProxy, use etching to generate initial contracts * etch all the contracts * git ignore local dumps * fix contracts/script/EtchInitialState.s.sol, use it also as setup for tests * fix GenerateAlloc for UpgradeEntryPoint, add allocations and test upgradeability * lint and cl fixes * temporarily disabled solhint in CI/CD * temporarily remove run_solidity_lint * temporarily remove lint form workflow * remove need for env function in test * build(deps): bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (#19) Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.0...v1.8.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jongwon Park <jwparktom@gmail.com> * feat(api): add epochs api (#176) * feat(api): add epochs api * feat(api): add epoch info api * feat(mint): update mint param type (#182) * feat(mint): update param type * feat(mint): make param value consistent among example and tests * feat(cli): add key conversion subcommand (#174) * feat(cli): add key conversion subcommand * adds uncompressed pubkey (hex) as input * fix(CI/CD): fix solhint (#190) * fix(solhint): rm redundant pre-commit linting hook * fix(solhint): update linting script & pkg version * chore(contracts): apply linting fixes * chore(cmd): fix validator flag linting issue --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jongwon Park <contact@parkjongwon.com> Co-authored-by: zsystm <124245155+zsystm@users.noreply.github.com> Co-authored-by: Jongwon Park <jwparktom@gmail.com> Co-authored-by: Narangde <hansol.lee@storyprotocol.xyz> Co-authored-by: zsystm <actor93kor@gmail.com> Co-authored-by: Haodi <82733821@qq.com> Co-authored-by: Ze <edisonz0718@gmail.com> Co-authored-by: Zerui Ge <gezerui1997@gmail.com> Co-authored-by: Ramarti <raul.mf86@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Seb <sebsadface@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some unused code. Change unnecessary panic in Wrap function.
issue: none