fix(evmengine): handle engine errors #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xHansLee
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
0xHansLee
force-pushed
the
hans/handle-engine-errors
branch
from
5ae1754
to
b9e0b91
Compare
0xHansLee
commented
Nov 21, 2024
edisonz0718
reviewed
Nov 25, 2024
| @@ -29,6 +35,11 @@ func makeProcessProposalRouter(app *App) *baseapp.MsgServiceRouter { | |||
| // It also updates some external state. | |||
| func makeProcessProposalHandler(router *baseapp.MsgServiceRouter, txConfig client.TxConfig) sdk.ProcessProposalHandler { | |||
| return func(ctx sdk.Context, req *abci.RequestProcessProposal) (*abci.ResponseProcessProposal, error) { | |||
| // Only allow 10s to process a proposal. Reject proposal otherwise. | |||
| timeoutCtx, timeoutCancel := context.WithTimeout(ctx.Context(), processTimeout) | |||
There was a problem hiding this comment.
Here in the comment it says allowing 10s to process, but processTimeout is set to 1 Minute. Do I miss anything here?
0xHansLee
force-pushed
the
hans/handle-engine-errors
branch
from
b9e0b91
to
94aa23e
Compare
jdubpark
approved these changes
Nov 26, 2024
edisonz0718
approved these changes
Nov 27, 2024
0xHansLee
force-pushed
the
hans/handle-engine-errors
branch
from
d37a1e0
to
4845b9f
Compare
Binary uploaded successfully 🎉📦 Version Name: 0.13.1-unstable-45f1946 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the commit from Omni to handle errors of engineAPI (omni-network/omni#2469).
issue: none