Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(evmstaking/keeper): add test cases for set address #67

Merged
merged 6 commits into from
Sep 2, 2024
Merged

test(evmstaking/keeper): add test cases for set address #67

merged 6 commits into from
Sep 2, 2024

Conversation

zsystm
Copy link
Collaborator

@zsystm zsystm commented Aug 28, 2024 •
edited
Loading

Increased test coverage from 0% to 87.5%

  • What's Covered
    • Most application logics written on the Story side, excluding SDK.
  • What’s Not Covered (Edge Cases Related to the SDK)
    • Failed to set of map (= collections)

issue: #64

@zsystm zsystm marked this pull request as ready for review August 28, 2024 04:18
@zsystm zsystm mentioned this pull request Aug 28, 2024
Open
@zsystm zsystm self-assigned this Sep 2, 2024
@zsystm zsystm force-pushed the zsystm/test/evmstaking/keeper/set_address branch from e5d9cfd to 2203d2c Compare September 2, 2024 07:48
@limengformal limengformal changed the title test(evmstaking/keeper): add test cases for set_address test(evmstaking/keeper): add test cases for set address Sep 2, 2024
@limengformal limengformal merged commit 186cfa5 into piplabs:main Sep 2, 2024
6 of 7 checks passed
@zsystm zsystm deleted the zsystm/test/evmstaking/keeper/set_address branch September 25, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limengformal limengformal limengformal approved these changes

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

@jdubpark jdubpark Awaiting requested review from jdubpark jdubpark is a code owner

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@ezreal1997 ezreal1997 Awaiting requested review from ezreal1997 ezreal1997 is a code owner

@leeren leeren Awaiting requested review from leeren leeren is a code owner

Assignees

@zsystm zsystm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsystm @limengformal