test(evmengine/keeper): add test cases for upgrades #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsystm
force-pushed
the
zsystm/test/evmengine/keeper/upgrades
branch
from
4dfecc9
to
2251991
Compare
zsystm
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
limengformal
approved these changes
Sep 6, 2024
zsystm
force-pushed
the
zsystm/test/evmengine/keeper/upgrades
branch
from
2251991
to
fe51c3f
Compare
zsystm
force-pushed
the
zsystm/test/evmengine/keeper/upgrades
branch
from
fe51c3f
to
a3bdb13
Compare
edisonz0718
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increased test coverage to 100%.
notes
I followed the existing test conventions for the evmengine module:
{file}_internal_test.gowithin the same package.In my opinion, it would be better for future maintainability to manage the tests with
TestSuite, similar to theevmstakingmodule. However, changing all the existing test code to this format would require a significant amount of work, so I have adhered to the current convention for now.If you guys have any different thoughts on this, please feel free to let me know.
issue: #81