Add the debug option and verbose (foreground) #1949
Conversation
I am proposing this PR, so we can debug and do foreground run (or start?) easily. I took "suspend" and "verbose" names from some other projects, so I think the user is familiar with it.
|
Hi @folker-kuhn. As this is your first PR can you please acknowledge that the code will be owned by Manorrock.com. I will only ask this one time, as that is all that is needed for contributing code back to us. About running in foreground, the |
|
I acknowledge the code in this PR and all further PRs I do to this project will be owned by Manorrock.com. Thanks! Okay, that is what I'll look at |
|
@folker-kuhn Thanks for the acknowledgement. I'll let @Thihup work with you on the PR as he already engaged. We can now start merging any of your contributions. Welcome and thank you! |
Adding --run option to start in background with a wait
Make sure all options in start.sh also apply when using run.sh
Touch the pid before the command, since there is some loop looking for it in the cmd, and the pid is otherwise created after it. We get a race here.
Co-authored-by: Thiago Henrique Hüpner <thihup@gmail.com>
|
@Thihup what happened with the last commit and test run? |
|
Error: Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.3.0:jar (attach-javadocs) on project piranha-pico-core: MavenReportException: Error while generating Javadoc: I don't think this is related to my commit? |
|
@folker-kuhn It looks like @mnriem added a new subproject. However, it does not have any classes yet. So the Javadoc is complaining about it. It is not related to your changes. Sorry for the confusion. |
|
@folker-kuhn Thank you for your first contribution! It is MUCH appreciated and sorry for the confusion with the build ;) |
Fixes #1954
I am proposing this PR, so we can debug and do foreground run (or start?) easily. I took "suspend" and "verbose" names from some other projects, so I think the user is familiar with it.