Fixes issue #3271 - Add support for skipping using skip property to Piranha Maven plugin

maven/plugins/piranha-maven-plugin/src/main/java/cloud/piranha/maven/plugins/piranha/BaseMojo.java

@@ -101,6 +101,12 @@ public abstract class BaseMojo extends AbstractMojo {
      */
     @Parameter(defaultValue = "${project.build.directory}/piranha", property = "piranha.runtimeDirectory", required = true)
     protected String runtimeDirectory;
+
+    /**
+     * Stores the skip property.
+     */
+    @Parameter(defaultValue= "false", property="piranha.skip")
+    protected boolean skip;
 
     /**
      * Stores the version of the Piranha runtime to use.

maven/plugins/piranha-maven-plugin/src/main/java/cloud/piranha/maven/plugins/piranha/RunMojo.java

@@ -46,18 +46,19 @@ public class RunMojo extends BaseMojo {
 
     @Override
     public void execute() throws MojoExecutionException {
-        try {
-            determineVersionToUse();
-            downloadDistribution();
-            extractDistribution();
-            copyWarFile();
-            startPiranhaAndWait();
-        } catch (IOException ioe) {
-            throw new MojoExecutionException(ioe);
+        if (!skip) {
+            try {
+                determineVersionToUse();
+                downloadDistribution();
+                extractDistribution();
+                copyWarFile();
+                startPiranhaAndWait();
+            } catch (IOException ioe) {
+                throw new MojoExecutionException(ioe);
+            }
         }
     }
 
-
     /**
      * Start Piranha using a JAR distribution.
      */

maven/plugins/piranha-maven-plugin/src/main/java/cloud/piranha/maven/plugins/piranha/StartMojo.java

@@ -46,14 +46,16 @@ public class StartMojo extends BaseMojo {
 
     @Override
     public void execute() throws MojoExecutionException {
-        try {
-            determineVersionToUse();
-            downloadDistribution();
-            extractDistribution();
-            copyWarFile();
-            startPiranha();
-        } catch (IOException ioe) {
-            throw new MojoExecutionException(ioe);
+        if (!skip) {
+            try {
+                determineVersionToUse();
+                downloadDistribution();
+                extractDistribution();
+                copyWarFile();
+                startPiranha();
+            } catch (IOException ioe) {
+                throw new MojoExecutionException(ioe);
+            }
         }
     }
 
@@ -126,7 +128,7 @@ private void startPiranha() throws IOException {
                 startJarPiranha();
             case "zip" ->
                 startZipPiranha();
-            default -> 
+            default ->
                 throw new IOException("Unable to determine distribution");
         }
         File pidFile = new File(runtimeDirectory + "/tmp/piranha.pid");

maven/plugins/piranha-maven-plugin/src/main/java/cloud/piranha/maven/plugins/piranha/StopMojo.java

@@ -51,24 +51,32 @@ public class StopMojo extends AbstractMojo {
      */
     @Parameter(defaultValue = "${project.build.directory}/piranha", required = true)
     private String runtimeDirectory;
-
+
+    /**
+     * Stores the skip property.
+     */
+    @Parameter(defaultValue= "false", property="piranha.skip")
+    private boolean skip;
+
     @Override
     public void execute() throws MojoExecutionException {
-        try {
-            if (!Files.deleteIfExists(new File(
-                    runtimeDirectory, "tmp/piranha.pid").toPath())) {
-                try {
-                    TimeUnit.SECONDS.sleep(5);
-                } catch (InterruptedException ex) {
-                    Thread.currentThread().interrupt();
-                }
-                if (Files.deleteIfExists(new File(
-                    runtimeDirectory, "tmp/piranha.pid").toPath())) {
-                    System.err.println("Unable to delete PID file");
+        if (!skip) {
+            try {
+                if (!Files.deleteIfExists(new File(
+                        runtimeDirectory, "tmp/piranha.pid").toPath())) {
+                    try {
+                        TimeUnit.SECONDS.sleep(5);
+                    } catch (InterruptedException ex) {
+                        Thread.currentThread().interrupt();
+                    }
+                    if (Files.deleteIfExists(new File(
+                            runtimeDirectory, "tmp/piranha.pid").toPath())) {
+                        System.err.println("Unable to delete PID file");
+                    }
                 }
+            } catch (IOException ioe) {
+                throw new MojoExecutionException(ioe);
             }
-        } catch (IOException ioe) {
-            throw new MojoExecutionException(ioe);
         }
     }
 }

pom.xml

@@ -797,9 +797,9 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <configuration>
-                    <encoding>UTF-8</encoding>
                     <consoleOutput>true</consoleOutput>
                     <failsOnError>true</failsOnError>
+                    <inputEncoding>UTF-8</inputEncoding>
                     <linkXRef>false</linkXRef>
                     <excludes>**/module-info.java</excludes>
                     <checkstyleRules>

test/embedded/springboot-virtualthreads/pom.xml

@@ -61,6 +61,7 @@
             <plugin>
                 <groupId>org.springframework.boot</groupId>
                 <artifactId>spring-boot-maven-plugin</artifactId>
+                <version>${spring-boot.version}</version>
                 <configuration>
                   <jvmArguments>
                       --enable-preview --add-modules=jdk.incubator.concurrent

test/embedded/springboot/pom.xml

@@ -50,6 +50,7 @@
             <plugin>
                 <groupId>org.springframework.boot</groupId>
                 <artifactId>spring-boot-maven-plugin</artifactId>
+                <version>${spring-boot.version}</version>
                 <configuration>
                     <!--
                   <jvmArguments>