Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3827 - Remove jakarta.assertion JavaDoc tag #3828

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fixes #3827 - Remove jakarta.assertion JavaDoc tag #3828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/impl/src/main/java/cloud/piranha/core/impl/DefaultJspManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
/**
* The default JspManager.
*
* @jakarta.assertion Servlet:JAVADOC:690
* @author Manfred Riem (mriem@manorrock.com)
*/
public class DefaultJspManager implements JspManager {
Expand Down
38 changes: 26 additions & 12 deletions core/impl/src/test/java/cloud/piranha/core/impl/RequestDispatcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ class RequestDispatcherTest {
/**
* Test forward method with a named RequestDispatcher.
*
* @jakarta.assertion Servlet:SPEC:181
* @jakarta.assertion Servlet:SPEC:181.1
* @jakarta.assertion Servlet:SPEC:181.2
* @jakarta.assertion Servlet:SPEC:181.3
* @jakarta.assertion Servlet:SPEC:181.4
* @jakarta.assertion Servlet:SPEC:181.5
* <p>
* This test validates Servlet:SPEC:181, Servlet:SPEC:181.1,
* Servlet:SPEC:181.2, Servlet:SPEC:181.3, Servlet:SPEC:181.4 and
* Servlet:SPEC:181.5
* </p>
*
* @throws Exception when a serious error occurs.
*/
@Test
Expand Down Expand Up @@ -122,7 +122,10 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
/**
* Test forward method on a named RequestDispatcher.
*
* @jakarta.assertion Servlet:SPEC:79
* <p>
* This test validates Servlet:SPEC:79
* </p>
*
* @throws Exception when a serious error occurs.
*/
@Test
Expand Down Expand Up @@ -160,7 +163,10 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
/**
* Test forward method on a named RequestDispatcher.
*
* @jakarta.assertion Servlet:SPEC:80
* <p>
* This test validates Servlet:SPEC:80
* </p>
*
* @throws Exception when a serious error occurs.
*/
@Test
Expand Down Expand Up @@ -236,7 +242,10 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
/**
* Test include method on a named RequestDispatcher.
*
* @jakarta.assertion Servlet:SPEC:192.1
* <p>
* This test validates Servlet:SPEC:192.1
* </p>
*
* @throws Exception when a serious error occurs.
*/
@Test
Expand Down Expand Up @@ -654,8 +663,10 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws Se
* Test include method using named RequestDispatcher and validate it throws
* an IllegalStateException when the response is already committed.
*
* @jakarta.assertion Servlet:SPEC:192.3
* @jakarta.assertion Servlet:SPEC:192.4
* <p>
* This test validates Servlet:SPEC:192.3 and Servlet:SPEC:192.4
* </p>
*
* @throws Exception when a serious error occurs.
*/
@Test
Expand Down Expand Up @@ -697,7 +708,10 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
* size to validate the response was committed after buffer overflow
* happened.
*
* @jakarta.assertion Servlet:SPEC:192.2
* <p>
* This test validates Servlet:SPEC:192.2
* </p>
*
* @throws Exception when a serious error occurs.
*/
@Test
Expand Down
3 changes: 1 addition & 2 deletions extension/eclipse-wasp/src/main/java/cloud/piranha/extension/wasp/WaspJspManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@

/**
* The WaSP manager delivered by the Jasper integration.
*
* @jakarta.assertion Servlet:JAVADOC:690
*
* @author Manfred Riem (mriem@manorrock.com)
*/
public class WaspJspManager implements JspManager {
Expand Down
5 changes: 4 additions & 1 deletion extension/eclipse-wasp/src/test/java/cloud/piranha/extension/wasp/JspDescriptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ class JspDescriptorTest {
/**
* Test getJspDescriptor method.
*
* @jakarta.assertion Servlet:JAVADOC:690
* <p>
* This test validates Servlet:JAVADOC:690.
* </p>
*
* @throws Exception when a serious error occurs.
*/
@Test
Expand Down
7 changes: 0 additions & 7 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,13 +582,6 @@
<configuration>
<additionalOptions>-html5</additionalOptions>
<docfilessubdirs>true</docfilessubdirs>
<tags>
<tag>
<name>jakarta.assertion</name>
<placement>a</placement>
<head>Assertion: </head>
</tag>
</tags>
</configuration>
</execution>
</executions>
Expand Down
Loading