Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4260 - Disable tests failing under Windows #4261

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Fixes #4260 - Disable tests failing under Windows #4261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
695cd78
Fixes #4260 - Disable tests failing under Windows
mnriem Nov 23, 2024
56cb3b6
Fixes #4260 - Disable tests failing under Windows
mnriem Nov 23, 2024
3153ab9
Fixes #4260 - Disable tests failing under Windows
mnriem Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/micro/helloworld/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
<build>
<finalName>helloworld</finalName>
<plugins>
<!--
<plugin>
<groupId>cloud.piranha.maven</groupId>
<artifactId>piranha-maven-plugin</artifactId>
Expand All @@ -71,6 +72,7 @@
<httpPort>${httpPort}</httpPort>
</configuration>
</plugin>
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Expand Down
2 changes: 2 additions & 0 deletions test/micro/helloworld/src/test/java/helloworld/HelloWorldServletIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@
import java.net.http.HttpResponse;
import java.net.http.HttpResponse.BodyHandlers;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

class HelloWorldServletIT {

@Disabled
@Test
void testHelloWorld() throws Exception {
HttpClient client = HttpClient.newHttpClient();
Expand Down
9 changes: 5 additions & 4 deletions test/micro/snoop/src/test/java/snoop/SnoopIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,14 @@
*/
package snoop;

import cloud.piranha.test.common.PiranhaStartup;
import com.gargoylesoftware.htmlunit.WebClient;
import com.gargoylesoftware.htmlunit.html.HtmlPage;
import java.io.File;
import me.alexpanov.net.FreePortFinder;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.AfterEach;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

/**
Expand Down Expand Up @@ -66,7 +64,7 @@ public class SnoopIT {
*/
@AfterAll
public static void afterAll() {
process.destroyForcibly();
// process.destroyForcibly();
}

/**
Expand All @@ -84,6 +82,7 @@ public void afterEach() {
*/
@BeforeAll
public static void beforeAll() throws Exception {
/*
port = FreePortFinder.findFreeLocalPort();
process = new ProcessBuilder()
.directory(new File("target"))
Expand All @@ -97,6 +96,7 @@ public static void beforeAll() throws Exception {
.start();

PiranhaStartup.waitUntilPiranhaReady(process, port);
*/
}

/**
Expand All @@ -112,6 +112,7 @@ public void beforeEach() {
*
* @throws Exception when a serious error occurs.
*/
@Disabled
@Test
public void testSnoop() throws Exception {
HtmlPage page = webClient.getPage("http://localhost:" + port + "/Snoop");
Expand Down
2 changes: 2 additions & 0 deletions test/servlet/crac/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
<build>
<finalName>crac</finalName>
<plugins>
<!--
<plugin>
<groupId>cloud.piranha.maven</groupId>
<artifactId>piranha-maven-plugin</artifactId>
Expand All @@ -93,6 +94,7 @@
<startTimeout>60</startTimeout>
</configuration>
</plugin>
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Expand Down
2 changes: 2 additions & 0 deletions test/servlet/faces/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
<build>
<finalName>faces</finalName>
<plugins>
<!--
<plugin>
<groupId>cloud.piranha.maven</groupId>
<artifactId>piranha-maven-plugin</artifactId>
Expand All @@ -84,6 +85,7 @@
<httpPort>${httpPort}</httpPort>
</configuration>
</plugin>
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Expand Down
2 changes: 2 additions & 0 deletions test/servlet/hello/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
<build>
<finalName>piranha-test-servlet-hello</finalName>
<plugins>
<!--
<plugin>
<groupId>cloud.piranha.maven</groupId>
<artifactId>piranha-maven-plugin</artifactId>
Expand All @@ -72,6 +73,7 @@
</execution>
</executions>
</plugin>
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-war-plugin</artifactId>
Expand Down
5 changes: 5 additions & 0 deletions test/servlet/hello/src/test/java/hello/HelloIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.net.http.HttpResponse;
import java.net.http.HttpResponse.BodyHandlers;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

/**
Expand All @@ -53,6 +54,7 @@ class HelloIT {
*
* @throws Exception when a serious error occurs.
*/
@Disabled
@Test
void testHelloWorldHtml() throws Exception {
HttpClient client = HttpClient.newHttpClient();
Expand All @@ -68,6 +70,7 @@ void testHelloWorldHtml() throws Exception {
*
* @throws Exception when a serious error occurs.
*/
@Disabled
@Test
void testHelloElJsp() throws Exception {
HttpClient client = HttpClient.newHttpClient();
Expand All @@ -83,6 +86,7 @@ void testHelloElJsp() throws Exception {
*
* @throws Exception when a serious error occurs.
*/
@Disabled
@Test
void testHelloJspJsp() throws Exception {
HttpClient client = HttpClient.newHttpClient();
Expand All @@ -98,6 +102,7 @@ void testHelloJspJsp() throws Exception {
*
* @throws Exception when a serious error occurs.
*/
@Disabled
@Test
void testHelloServlet() throws Exception {
HttpClient client = HttpClient.newHttpClient();
Expand Down
2 changes: 2 additions & 0 deletions test/servlet/helloworld/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
<build>
<finalName>helloworld</finalName>
<plugins>
<!--
<plugin>
<groupId>cloud.piranha.maven</groupId>
<artifactId>piranha-maven-plugin</artifactId>
Expand All @@ -85,6 +86,7 @@
<httpPort>${httpPort}</httpPort>
</configuration>
</plugin>
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Expand Down
2 changes: 2 additions & 0 deletions test/servlet/helloworld/src/test/java/helloworld/HelloWorldIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
import java.net.http.HttpResponse;
import java.net.http.HttpResponse.BodyHandlers;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

class HelloWorldIT {

@Disabled
@Test
void testHelloWorldHtml() throws Exception {
HttpClient client = HttpClient.newHttpClient();
Expand Down
2 changes: 2 additions & 0 deletions test/servlet/pages/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
<build>
<finalName>pages</finalName>
<plugins>
<!--
<plugin>
<groupId>cloud.piranha.maven</groupId>
<artifactId>piranha-maven-plugin</artifactId>
Expand All @@ -64,6 +65,7 @@
<httpPort>${httpPort}</httpPort>
</configuration>
</plugin>
-->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
Expand Down
2 changes: 2 additions & 0 deletions test/servlet/pages/src/test/java/hello/HelloIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@
import java.net.http.HttpResponse.BodyHandlers;
import java.time.Duration;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

public class HelloIT {

private final String portNumber = System.getProperty("httpPort");

@Disabled
@Test
public void testPagesHelloJsp() throws Exception {
HttpClient client = HttpClient
Expand Down
3 changes: 3 additions & 0 deletions test/webprofile/helloworld/src/test/java/helloworld/HelloWorldIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import java.net.http.HttpResponse;
import java.net.http.HttpResponse.BodyHandlers;
import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

/**
Expand All @@ -47,6 +48,7 @@ class HelloWorldIT {
*
* @throws Exception when a serious error occurs.
*/
@Disabled
@Test
void testIndexHtml() throws Exception {
HttpClient client = HttpClient.newHttpClient();
Expand All @@ -62,6 +64,7 @@ void testIndexHtml() throws Exception {
*
* @throws Exception when a serious error occurs.
*/
@Disabled
@Test
void testHelloWorldJsp() throws Exception {
HttpClient client = HttpClient.newHttpClient();
Expand Down
Loading