Added python program to resize an image. #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a python3 program to read and resize an image to half its original size.
Added a python program to calculate mean of an array. The code currently takes an example array to test the code. One can change it as per need.
dnery
reviewed
Oct 15, 2019
| @@ -0,0 +1,13 @@ | |||
| import numpy as np | |||
There was a problem hiding this comment.
Are you sure this file should be a part of your contribution?
If so, how about moving it to misc/calc_mean.py?
Another tip: make it so that the array to be sorted can be passed in as an argument or input to your program! 😃
|
|
||
| files = os.listdir() | ||
| for i in files : | ||
| if i[-5:] == ".jpeg": |
There was a problem hiding this comment.
I feel like I'm reading a programming marathon code snippet! 😆
Suggested change
| if i[-5:] == ".jpeg": | |
| if i.endswith('.jpeg'): |
Jokes aside, how about moving this to digital_image_processing/manipulation/resize_image.py?
dnery
requested changes
Oct 15, 2019
|
Marking this as stale. If you'd still like to follow up on the review, just post a comment right here and we'll reopen the PR! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a python3 program to read and resize an image to half its original size.
Hacktoberfest issue (#66)
Description
Please include a small description of your algorithm/data structure and add reference to the Hacktoberfest issue (#66)