Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New tab" button after last tab isn't visible in Firefox 29+ #684

Closed
Infocatcher opened this issue Apr 11, 2014 · 4 comments
Closed

"New tab" button after last tab isn't visible in Firefox 29+ #684

Infocatcher opened this issue Apr 11, 2014 · 4 comments

Comments

@Infocatcher
Copy link
Contributor

We always have #tabbrowser-tabs[overflow="true"] even for only one opened tab.
And therefore "New tab" button is displayed at the end of tab bar (oh, this is original one because there is two buttons: movable on toolbar and yet another after las tab).

@Infocatcher
Copy link
Contributor Author

Oops, this is conflict with Private Tab with fixes for Infocatcher/Private_Tab#137 (and all works fine with extensions.privateTab.fixAfterTabsButtonsAccessibility = false) :(

@Infocatcher
Copy link
Contributor Author

Now this fix should be disabled for vertical tab bar. It shouldn't be needed in this case anyway. But this bug is very strange though.

Infocatcher added a commit to Infocatcher/Private_Tab that referenced this issue Apr 12, 2014
Previous implementation works wrong with button's padding (and introduces horizontal overflow in Tree Style Tab)
(#137, piroor/treestyletab#684)
@Infocatcher
Copy link
Contributor Author

But this bug is very strange though.

Oh, I forgot about button's padding, should be better now: Infocatcher/Private_Tab@9e4a255

@Infocatcher
Copy link
Contributor Author

Summary
This is only my fault: I set too big horizontal padding to .tabs-newtab-button > .toolbarbutton-icon and #tabbrowser-tabs[overflow="true"] appears as a result of horizontal overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant